feat(ssr): implement fixes for known issues #5188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
approved these changes
Feb 4, 2025
| @@ -9,5 +9,6 @@ export default class GetterClassList extends LightningElement { | |||
| classList.remove('b'); | |||
|
|
|||
| expect(this.getAttribute('class')).toBe('a c d-e'); | |||
| expect(() => this.classList.length).not.toThrow(); | |||
There was a problem hiding this comment.
Suggested change
| expect(() => this.classList.length).not.toThrow(); | |
| expect(this.classList.length).toBe(3); |
We know what it should be, why not check that directly?
There was a problem hiding this comment.
I had that originally. Original SSR implementation returns undefined. When we retire @lwc/engine-server, we may want to revisit things like this.
| @@ -0,0 +1,4 @@ | |||
| <template> | |||
| Value: {foo.value} | |||
| <!-- Dude --> | |||
| @@ -215,7 +215,13 @@ const visitors: Visitors = { | |||
| break; | |||
| } | |||
| }, | |||
| Super(path, _state) { | |||
| Super(path, state) { | |||
There was a problem hiding this comment.
Does this visitor also apply to super.method() calls in other methods?
| @@ -215,7 +215,13 @@ const visitors: Visitors = { | |||
| break; | |||
| } | |||
| }, | |||
| Super(path, _state) { | |||
| Super(path, state) { | |||
There was a problem hiding this comment.
aside: we should validate whether the other visitors need this guard #5189.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
As we've rendered some internal components under the new SSR implementation, a handful of issues were identified. This PR introduces corresponding test cases and fixes.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
Further closes the gap between SSRv1 and SSRv2.
GUS work item
W-17740271