Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add environment variable to disable LWC version mismatch loglines #5187

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nrkruk
Copy link

@nrkruk nrkruk commented Feb 3, 2025

Details

When using LWR local dev for experience sites, every SSR request logs an LWC version mismatch error. This is due to the fact that the engine-server is intentionally reloaded on a per page basis and not cached in memory. Therefore the mechanisms in place to only log a the version mismatch once do not work. The logging noise from this makes observing actual useful errors during SSR more difficult.

My change just introduces a new environment variable that can be set on the LWR side to disable this logging during local development.

Would like to backport this also to spring25

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

GUS work item

@W-17740011@

@nrkruk nrkruk requested a review from a team as a code owner February 3, 2025 23:24
if (process?.env?.SKIP_LWC_VERSION_MISMATCH_CHECK === 'true') {
warned = true; // skip printing out version mismatch errors when env var is set
return;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd need a build-time complement to this environment variable. E.g. when we compile @lwc/engine-dom, this code path should turn into if (false) { and be minified away.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divmain not super familiar with the lwc codebase, can you point me where to make this change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divmain is this the right place to do it?

function sharedPlugins() {
const engineBrowserConfig = ['@lwc/engine-server', '@lwc/engine-dom'].includes(packageName) && {
// This is only used inside @lwc/engine-dom and @lwc/engine-server
// Elsewhere, it _not_ be replaced, so that it can be replaced later (e.g. in @lwc/engine-core)
'process.env.IS_BROWSER': packageName === '@lwc/engine-dom' ? 'true' : 'false',
};
return [
typescript({
tsconfig: path.join(packageRoot, 'tsconfig.json'),
exclude: ['**/__tests__/**'],
noEmitOnError: !watchMode, // in watch mode, do not exit with an error if typechecking fails
...(watchMode && {
incremental: true,
outputToFilesystem: true,
}),
declarationDir: 'dist', // must match `output.file` in the overall Rollup config
}),
replace({
values: {
...engineBrowserConfig,
'process.env.LWC_VERSION': JSON.stringify(version),
},
preventAssignment: true,
}),
];
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the replace plugin is correct.

Comment on lines +64 to +68
}).not.toLogErrorDev(
new RegExp(
`LWC WARNING: current engine is v${process.env.LWC_VERSION}, but template was compiled with v123.456.789`
)
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}).not.toLogErrorDev(
new RegExp(
`LWC WARNING: current engine is v${process.env.LWC_VERSION}, but template was compiled with v123.456.789`
)
);
}).not.toLogErrorDev(/v123\.456\.789/);

Checking that we're not logging such a long message feels easy to get an accidental false positive, if the error text ever changes. We should just check for keywords to be more flexible.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure I can make it more generic

@@ -38,6 +38,11 @@ export function checkVersionMismatch(
) {
const versionMatcher = func.toString().match(LWC_VERSION_COMMENT_REGEX);
if (!isNull(versionMatcher) && !warned) {
if (process?.env?.SKIP_LWC_VERSION_MISMATCH_CHECK === 'true') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process?.env
Are we expecting to encounter a scenario where the process variable is declared but null/undefined?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was just being extra cautious - I didn't know how things were compiled (and what is shipped to the browser vs whats available in server side engine). Didn't want to unintentionally break something for this one usecase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants