fix: v2 non-field api support #5178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhefferman-sfdc
commented
Jan 30, 2025
| @@ -0,0 +1,14 @@ | |||
| <x-parent> | |||
There was a problem hiding this comment.
Added this test for symmetry (I know it is covered elsewhere too)
wjhsf
reviewed
Jan 30, 2025
| @@ -78,7 +78,7 @@ export class LightningElement implements PropsAvailableAtConstruction { | |||
| [SYMBOL__SET_INTERNALS]( | |||
| props: Properties, | |||
| attrs: Attributes, | |||
| publicFields: Set<string>, | |||
| api: Set<string>, | |||
There was a problem hiding this comment.
I like publicFields better. Makes the high-level intent more obvious.
| import { LightningElement, api } from 'lwc'; | ||
|
|
||
| export default class Child extends LightningElement { | ||
| @api set setterGetterApi(value) { |
There was a problem hiding this comment.
Suggested change
| @api set setterGetterApi(value) { | |
| @api set setter(value) { |
Can we also add a @api get getter in this test, to make sure we cover both?
wjhsf
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-17701540