chore(prettier): format fixture input files #4972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
commented
Nov 27, 2024
Comment on lines
-6
to
-7
| public/ | ||
| types/ |
There was a problem hiding this comment.
We don't have any directories called public or types that we want to ignore, so we don't need this in the config.
nolanlawson
reviewed
Nov 27, 2024
| packages/@lwc/style-compiler/src/__tests__/fixtures/**/actual.css | ||
| packages/@lwc/babel-plugin-component/src/__tests__/fixtures/**/actual.js | ||
|
|
||
| # TODO: Why do these have JS in them? |
There was a problem hiding this comment.
These have JS in them because we are testing how Node/module resolution works for .js files with a particular directory structure / name.
wjhsf
commented
Nov 27, 2024
| @@ -11,11 +11,11 @@ To enable importing [templates](https://lwc.dev/guide/html_templates) or [styles | |||
|
|
|||
| ```ts | |||
| // ./types/global.d.ts | |||
| import '@lwc/types' | |||
| import '@lwc/types'; | |||
There was a problem hiding this comment.
TIL prettier can handle code blocks in markdown!
nolanlawson
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
There is of course a chance that you've formatted some files where we had an intentional error. But I think your blocklist in .prettierignore looks right to me, and I checked all the non-whitespace changes and they look to be unimportant.
Let's do this! Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Another minor nuisance solved!
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item