chore(ssr): remove unique var generator #4970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've moved to a pattern of using block statements for more descriptive variable names. The `getUniqueVar` helper is no longer used anywhere.
nolanlawson
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The SSR compiler generates repeated patterns that often share the same scope (e.g. property access), but the implementations require the use of variables. In the initial version of the compiler, we used a shared global state to generate sequential variable names (i.e.
a,b,c, ...). However, more recently we have switched to using block statements (e.g.{ const value = 'string'; ... }) to create new scopes and avoid variable collision. With #4963 merged, we no longer use the unique variable generator, so this PR removes it.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item