chore(ssr-compiler): Align isValidIdentifier with babel-plugin-component impl

[jhefferman-sfdc]

Details

Fixes: #4826

Does this pull request introduce a breaking change?

• 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

• 🤞 No, it does not introduce an observable change.

GUS work item

W-17206167

[wjhsf]

Suggested change

	"@types/estree": "^1.0.6",
	"@types/babel-types": "^7.0.16"
	"@types/estree": "^1.0.6",

We shouldn't need @types/babel-types, because that's for babel-types and we're using @babel/types. (Unless there's something weird going on with nested dependencies?)

[jhefferman-sfdc]

Good call, thanks

[wjhsf]

If we're not adding any extra logic, we should probably remove this and just use the helper directly.

[jhefferman-sfdc]

Do you mean the isIdentifierName helper? I checked the implementation and it seemed a little different in terms of reserved names, etc isIdentifierName vs isValidES3Identifier

[nolanlawson]

I think Will just means that we don't need to re-declare a const here – we can just use isValidES3Identifier directly.

BTW it'd be great to add a comment pointing to this code so it's clear why we are including a random Babel dep in our Meriyah code :)

lwc/packages/@lwc/babel-plugin-component/src/decorators/wire/transform.ts

Lines 61 to 63 in 4845840

	const isInvalidMemberExpr = memberExprPaths.some(
	(maybeIdentifier) =>
	!(t.isValidES3Identifier(maybeIdentifier) && maybeIdentifier.length > 0)

[nolanlawson]

BTW I was curious if the reservedKeywords actually matters here, and it looks like no. This is a valid object:

Click to see

const obj = {
  NaN: 'foo',
  arguments: 'foo',
  break: 'foo',
  case: 'foo',
  catch: 'foo',
  class: 'foo',
  const: 'foo',
  continue: 'foo',
  debugger: 'foo',
  default: 'foo',
  delete: 'foo',
  do: 'foo',
  else: 'foo',
  enum: 'foo',
  eval: 'foo',
  export: 'foo',
  extends: 'foo',
  false: 'foo',
  finally: 'foo',
  for: 'foo',
  function: 'foo',
  if: 'foo',
  implements: 'foo',
  import: 'foo',
  in: 'foo',
  instanceof: 'foo',
  interface: 'foo',
  let: 'foo',
  new: 'foo',
  null: 'foo',
  package: 'foo',
  private: 'foo',
  protected: 'foo',
  public: 'foo',
  return: 'foo',
  static: 'foo',
  super: 'foo',
  switch: 'foo',
  this: 'foo',
  throw: 'foo',
  true: 'foo',
  try: 'foo',
  typeof: 'foo',
  undefined: 'foo',
  var: 'foo',
  void: 'foo',
  while: 'foo',
  with: 'foo',
  yield: 'foo',
}

[nolanlawson]

So we can remove reservedKeywords entirely since it's not used anywhere.

[jhefferman-sfdc]

Ahh sorry yes that sounds good, thank you both

[nolanlawson]

Let's alphabetize please :)

[nolanlawson]

Minor nitpicks, otherwise looks good!