test(ssr): add tests for @wire errors
#4915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Nov 21, 2024
| 'expected.html': '', | ||
| 'error.txt': message ?? '', | ||
| }; | ||
| } |
There was a problem hiding this comment.
I figure we might as well start testing compiler errors in engine-server. It's convenient for SSR tests since they effectively do double-duty as a compiler and runtime.
wjhsf
reviewed
Nov 21, 2024
| const message = err?.message?.match(/(LWC\d+[^\n]+)/)?.[1]; | ||
| return { | ||
| 'expected.html': '', | ||
| 'error.txt': message ?? '', |
There was a problem hiding this comment.
Suggested change
| 'error.txt': message ?? '', | |
| 'error.txt': err?.message ?? '', |
Unless @lwc/errors is weird, err.message doesn't include the stack.
There was a problem hiding this comment.
err.message does include the stack here because the error actually comes from Babel-via-Rollup.
Also if err?.message is nullish, then message will be nullish as well.
wjhsf
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Follow-up to #4910. This doesn't test all the
@wireerrors, but it's a start.These are copied from the
wire-decorator/throws-*tests inbabel-plugin-component.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?