Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: consistent fixture tests for disallowed @api props #4045

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

nolanlawson
Copy link
Contributor

Details

This is extracted out of #4044 since it's not strictly related to that PR.

This just adds tests to confirm the behavior of disallowed @api properties defined here:

// This set is for attributes that can never be defined
// by users on their components.
// We throw for these.
const DISALLOWED_PROP_SET = new Set(['is', 'class', 'slot', 'style']);

Previously, only some of these props were tested. Now, they are all tested.

Does this pull request introduce a breaking change?

  • ✅ No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • ✅ No, it does not introduce an observable change.

@nolanlawson nolanlawson requested a review from a team as a code owner March 11, 2024 22:49
@nolanlawson nolanlawson merged commit 09f7b4c into master Mar 12, 2024
9 checks passed
@nolanlawson nolanlawson deleted the nolan/disallowed-tests branch March 12, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants