fix: remove string.prototype.matchAll polyfill #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
String.prototype.matchallis available in Node v12+. It should be safe to remove this polyfill.Technically this is a breaking change, but historically we have not made any guarantees about Node compatibility, nor do we test in any version of Node other than the latest LTS. I suspect Node v10 is already broken anyway, and in any case, nobody should be using it.
This does not merit a major version bump IMO.
Does this pull request introduce a breaking change?
See above.
Does this pull request introduce an observable change?
GUS work item