Skip to content

Commit

Permalink
chore: pin CI tests to chrome 121 (#4010)
Browse files Browse the repository at this point in the history
  • Loading branch information
nolanlawson authored Feb 22, 2024
1 parent b4411c8 commit be09660
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,21 @@ jobs:
node-version: "18.18.0"
cache: 'yarn'

# Needed for perf smoke tests, matches the chromedriver version installed by tachometer(https://github.com/google/tachometer/blob/main/README.md#on-demand-dependencies)
# version number can be found here https://www.googleapis.com/storage/v1/b/chromium-browser-snapshots/o?delimiter=/&prefix=Linux_x64/119
- name: Setup chrome v119
# Needed for perf smoke tests, matches the chromedriver version installed by tachometer (https://github.com/google/tachometer/blob/main/README.md#on-demand-dependencies)
# chrome-version documentation can be found here: https://github.com/browser-actions/setup-chrome?tab=readme-ov-file#usage
- name: Setup chrome v121
uses: browser-actions/setup-chrome@v1
with:
chrome-version: 1194751
chrome-version: 121
id: setup-chrome

- name: Install dependencies
run: yarn install --frozen-lockfile

# Pin chromedriver to the same version as Chrome above, so Tachometer uses this version.
# See: https://github.com/google/tachometer#on-demand-dependencies
- name: Install chromedriver v119
run: yarn add -W chromedriver@^119
- name: Install chromedriver v121
run: yarn add -W chromedriver@^121

- name: Check package.json integrity
run: node ./scripts/tasks/check-and-rewrite-package-json.js --test
Expand Down

0 comments on commit be09660

Please sign in to comment.