Merge pull request #210 from Rodrigodd/fix-rr

Update rr-replay.py to work with rr 5.8.0

lib/rr-replay.py

@@ -1,21 +1,20 @@
 #!/usr/bin/env python3
 
 import asyncio
-import pipes
 import sys
+import shlex
+import re
 
 # rr replay refuses to run outside of a pty. But it allows
 # attaching a gdb remotely.
 
 
 async def run_gdb(cmd):
-    args = [f'"{pipes.quote(a)}"' for a in sys.argv[1:]]
-    parts = cmd.split()
+    parts = shlex.split(cmd)
     gdb_idx = parts.index('gdb')
     if gdb_idx != -1:
-        parts = parts[:gdb_idx+1] + args + parts[gdb_idx+1:]
-        cmd = " ".join(parts)
-    gdb_proc = await asyncio.create_subprocess_shell(cmd)
+        parts = parts[:gdb_idx+1] + sys.argv[1:] + parts[gdb_idx+1:]
+    gdb_proc = await asyncio.create_subprocess_exec(*parts)
     await gdb_proc.communicate()
     return gdb_proc.returncode
 
@@ -34,9 +33,11 @@ async def run(cmd):
         cmd,
         stderr=asyncio.subprocess.PIPE)
 
+    header_regex = re.compile(b'Launch \\w+ with$')
+
     # Check it launched
     header = await rr_proc.stderr.readline()
-    if header != b'Launch gdb with\n':
+    if not header_regex.match(header):
         rest = await rr_proc.stderr.read()
         raise RuntimeError(f"Unexpected: {header.decode()}{rest.decode()}")