Return QString by value

sakertooth · Feb 13, 2025 · d2b1e40 · d2b1e40
1 parent 6602e85
commit d2b1e40
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/include/Sample.h b/include/Sample.h
@@ -91,7 +91,7 @@ class LMMS_EXPORT Sample
 		Loop loopMode = Loop::Off) const -> bool;
 
 	auto sampleDuration() const -> std::chrono::milliseconds;
-	auto sampleFile() const -> const QString& { return m_buffer->audioFile(); }
+	auto sampleFile() const -> QString { return m_buffer->audioFile(); }
 	auto sampleRate() const -> int { return m_buffer->sampleRate(); }
 	auto sampleSize() const -> size_t { return m_buffer->size(); }
 

diff --git a/include/SampleClip.h b/include/SampleClip.h
@@ -56,7 +56,7 @@ class SampleClip : public Clip
 
 	void changeLength( const TimePos & _length ) override;
 	void changeLengthToSampleLength();
-	const QString& sampleFile() const;
+	QString sampleFile() const;
 	bool hasSampleFileLoaded(const QString & filename) const;
 
 	void saveSettings( QDomDocument & _doc, QDomElement & _parent ) override;

diff --git a/src/core/SampleClip.cpp b/src/core/SampleClip.cpp
@@ -120,7 +120,7 @@ void SampleClip::changeLengthToSampleLength()
 
 
 
-const QString& SampleClip::sampleFile() const
+QString SampleClip::sampleFile() const
 {
 	return m_sample.sampleFile();
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -120,7 +120,7 @@ void SampleClip::changeLengthToSampleLength() @@
-    const QString& SampleClip::sampleFile() const
+    QString SampleClip::sampleFile() const
     {
     	return m_sample.sampleFile();
     }
@@ Expand Down @@