-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow build for qt6 #9
Conversation
cbced71
to
3702c7a
Compare
If I read correctly the PR is about supporting Qt 6. Please change the
commit message accordingly.
|
@Thaodan fixed |
e7a5b32
to
a9cc360
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one build error in tests/tst_events/tst_events.cpp and server.pro build should be cleaned so that we'd have just timed service & binary and etc scripts.
@rainemak fixed |
I forgot to comment about the spec. Following files are currently referring to the %{name} i.e. to timed-qt5. One option is that you'd defined for example "%define service_name timed" at the beginning of the spec and refer to that instead.
Changes are needed to %install, %post, %preun, %postun, and %files sections (at least). Without testing complete build on %files section as far as I can see only remaining %{name} reference should be in %{_libdir}/lib%{name}.so.* In addition to above, the setcapts-timed-qt5.sh is no yet renamed to setcaps-timed.sh. No need to duplicate that either, only change would be /usr/bin/timed change on setcap and fixing the echo line. |
@rainemak fix again ^_^ |
Thank you. I'll check again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix still %post, %preun, and %postun sections from the spec. There's also one error in the %install and timed.service symlinking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is good, I'll merge now.
No description provided.