Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow build with Qt6 #1

Closed
wants to merge 1 commit into from
Closed

Allow build with Qt6 #1

wants to merge 1 commit into from

Conversation

jmlich
Copy link
Contributor

@jmlich jmlich commented Sep 9, 2023 •
edited
Loading

todo:

  • mlite related commit d829756 should be probably removed or is it acceptable for upstream?
  • fromTime_t(), toTime_t(), setTime_t() should probably contain #ifdef
  • need to check if from/to/setTime_t date type rages are okay. Eventually change to qint64
  • need to check when enableTestMode -> setTestModeEnabled was done and add #ifdef eventually

@jmlich jmlich mentioned this pull request Sep 9, 2023
Open
52 tasks
@jmlich
Copy link
Contributor Author

jmlich commented Sep 14, 2023

I believe the overflow when int is used instead of qint64 for is not necessary for now.

@jmlich jmlich changed the title WIP: Allow build with Qt6 Allow build with Qt6 Sep 14, 2023
pvuorela
pvuorela reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly seems ok, but couple small comments.

src/lib/vkpostsdatabase.cpp
vkPost->replyPostId = extra.value(POST_REPLY_POST_ID_KEY).toInt();
vkPost->friendsOnly = extra.value(POST_FRIENDS_ONLY_KEY).toBool();
vkPost->signerId = extra.value(POST_SIGNER_ID_KEY).toInt();
vkPost->fromId = QVariant(extra.value(POST_FROM_ID_KEY)).toInt();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, not following. value() on QVariantMap should already return a QVariant?

Copy link
Contributor Author

@jmlich jmlich Nov 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, I wasn't able to compile it without that. I need to check it again

@pvuorela
Copy link
Contributor

Not to get stuck on the QVariantMap, I pushed all the other changes now. Closing this now. If any further need, can open new PRs.

@pvuorela pvuorela closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvuorela pvuorela pvuorela left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmlich @pvuorela