Fixup qt6 build #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sledges ping |
Thaodan
requested changes
Aug 7, 2023
neochapay
force-pushed
the
qt6
branch
3 times, most recently
from
2f28550 to
25b01c5
Compare
pvuorela
approved these changes
Nov 27, 2023
| #include <QtGlobal> | ||
| #if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) | ||
| #include <iodata-qt6/storage.h> | ||
| #elif QT_VERSION >= QT_VERSION_CHECK(5, 0, 0) |
There was a problem hiding this comment.
These could have been just #else, but oh well.
PureTryOut
reviewed
Jul 24, 2024
| @@ -1 +1,6 @@ | |||
| #include <QtGlobal> | |||
There was a problem hiding this comment.
Hey @neochapay this import doesn't actually exist right now. Instead (for Qt5) this would be qt5/QtCore/QtGlobal. Is some configuration missing in the .pro files to make this work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.