-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating Gymnasium #222
Conversation
This implementation leaves the Gym envpool part entirely unmodified. My changes add a Gymnasium option, which mostly mirrors the Gym option. Specs now have the additional attributes Were these roughly the changes we had in mind @Trinkle23897? I hope I understood you correctly on discord :). |
That makes sense! I’ll take a look these days. Great job and huge thanks! |
CarRacingEnvSpec, CarRacingDMEnvPool, CarRacingGymEnvPool = py_env( | ||
_CarRacingEnvSpec, _CarRacingEnvPool | ||
) | ||
( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Trinkle23897 Would it be better that we can make this less verbose? e.g. with a helper function like
def register_to_py(cpp_shared_lib):
dict_of_name_to_env = py_env(cpp_shared_lib)
globals().update(dict_of_name_to_env)
__all__ = dict_of_name_to_env.keys()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, we could make this change as a separate PR after this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me
This PR leaves gym as it is and adds gymnasium environments in an analogous way.