Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mem leaks #492

Merged
merged 22 commits into from
Apr 23, 2021
Merged

Fix mem leaks #492

merged 22 commits into from
Apr 23, 2021

Conversation

SeeSpotRun
Copy link
Collaborator

No description provided.

SeeSpotRun added 22 commits April 18, 2021 06:57
@SeeSpotRun
file: reference-count files and digests
e67e1df
@SeeSpotRun
preprocess: fix mem leak on other_lint
cb6d85f
@SeeSpotRun
tests: workaround for leaky treemerge so can find any other leaks
dbe8863
@SeeSpotRun
file: make rm_file_ref return file for convenience
ed45ed3
@SeeSpotRun
sh: fix possible invalid access to self->last_original after free
b3f8032
@SeeSpotRun
treemerge: fix leaks
490fec4
@SeeSpotRun
cmdline: don't let md-scheduler create mount table if --no-mount-table
dd11b31
@SeeSpotRun
file: check for zero-size file slices BEFORE creating file
f46cf15
@SeeSpotRun
traverse: not using RM_LINT_TYPE_DUPE_DIR_CANDIDATE (yet)
995aa53
@SeeSpotRun
preprocess: free ignored hardlinks
744e1fa
@SeeSpotRun
traverse (re-) fix mem leak from rm_traverse_rel_realpath()
b961cb0
@SeeSpotRun
checksum: fix bug when freeing rm_digest_paranoid_copy()
f85d101
@SeeSpotRun
Merge branch 'develop' into fix-mem-leaks
aea0cb3
@SeeSpotRun
Revert "traverse: not using RM_LINT_TYPE_DUPE_DIR_CANDIDATE (yet)"
8b8bf87 
This reverts commit 995aa53.
@SeeSpotRun
reflink: fix mem leak on GOptionContext
0daa8d0
@SeeSpotRun
traverse, cmdline: still run main session if no files found, if dirs …
f5a3d0f 
…found
@SeeSpotRun
traverse: fix mem leak on un-freed RmTravBuffer
5570710
@SeeSpotRun
cmdline: add option to keep going if one or more bad paths passed
a6b48d8
@SeeSpotRun
preprocess: do proper clean-up of tables->size_groups
efdcb27
@SeeSpotRun
file: rm_file_unref_full: also unref hardlink cluster files (mem leak…
4a7f453 
… fix)
@SeeSpotRun
tests: workaround for valgrind mis-handling of FICLONE ioctl
87d7097
@SeeSpotRun
file: report 0 actual_file_size for non-duplicate-file types
3c1a8e2
@SeeSpotRun
Copy link
Collaborator Author

It's been a long while since the full testsuite ran leak-free:

$ sudo RM_TS_DIR=testdir RM_TS_USE_VALGRIND=1 RM_TS_CHECK_LEAKS=1 RM_TS_PEDANTIC=1 nosetests -sxv --eval-attr="not slow and not valgrind_issue"

Ran 231 tests in 8288.592s

OK

@SeeSpotRun SeeSpotRun merged commit 3ff9809 into sahib:develop Apr 23, 2021
@SeeSpotRun SeeSpotRun mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SeeSpotRun