Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing links #17

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Add missing links #17

merged 1 commit into from
Nov 21, 2022

Conversation

soehms
Copy link
Member

@soehms soehms commented Nov 21, 2022

Currently the migration script doesn't convert links that don't have a display text. This will be fixed here.

@mkoeppe mkoeppe merged commit d96f423 into sagemath:master Nov 21, 2022
@mkoeppe
Copy link

mkoeppe commented Nov 21, 2022

Thanks!

@mkoeppe
Copy link

mkoeppe commented Nov 21, 2022

However, links such as https://github.com/sagemath/trac_to_gh/wiki/symbolics/maxima.md are strange

@soehms
Copy link
Member Author

soehms commented Nov 22, 2022

However, links such as https://github.com/sagemath/trac_to_gh/wiki/symbolics/maxima.md are strange

I tested locally with grip which gives you the rendered version. Even from the root of a GitHub repository these pages are rendered. I've no idea why from the wiki you get it raw.

@soehms soehms deleted the add_missing_links branch November 22, 2022 07:19
@soehms
Copy link
Member Author

soehms commented Nov 22, 2022

However, links such as https://github.com/sagemath/trac_to_gh/wiki/symbolics/maxima.md are strange

I tested locally with grip which gives you the rendered version. Even from the root of a GitHub repository these pages are rendered. I've no idea why from the wiki you get it raw.

The reason seems to be that I added the extension .md (since without I got a 404 error in my tests, see this stackoverflow question). Another difference to usual relative links is, that sub-directory paths have to be stripped. I will take care of that in the next PR #19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants