Skip to content

Added the rank method under ModulesWithBasis.ParentMethod. #39693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2025
Merged

Added the rank method under ModulesWithBasis.ParentMethod. #39693

merged 3 commits into from
Mar 22, 2025

Conversation

HenryWu2101
Copy link
Contributor

@HenryWu2101 HenryWu2101 commented Mar 13, 2025 •
edited
Loading

#34445
It is based on the understanding that dimension is equal rank under the context, assuming rank defined for infinite dimensional space.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@HenryWu2101
Added the rank method under ModulesWithBasis.ParentMethod.
4444f25 
It is based on the understanding that dimension is equal rank under the context,
assuming rank defined for infinite dimensional space.
tscrim
tscrim requested changes Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this PR; sorry it took so long for me to look at it.

Just a little doc tweak suggestion. Otherwise LGTM.

@HenryWu2101 HenryWu2101 requested a review from tscrim March 20, 2025 03:06
tscrim
tscrim approved these changes Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Once the bots come back (morally) green, I will set a positive review.

@HenryWu2101
Copy link
Contributor Author

Hi so I checked and figured out why the lint keeps failing. It was due to some minor code style violations (3 blank lines contains spaces). I've edited out the spaces w/o other changes in the latest commit.

@HenryWu2101
Corrected the coding style violation
49f22e9 
This commit only changes coding style violation in the comment. No code is altered.
@HenryWu2101 HenryWu2101 requested a review from tscrim March 20, 2025 05:26
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 49f22e9; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tscrim
Copy link
Collaborator

tscrim commented Mar 21, 2025

Positive review (failing test is unrelated).

@vbraun vbraun merged commit 6bacecc into sagemath:develop Mar 22, 2025
23 of 24 checks passed
@HenryWu2101 HenryWu2101 deleted the rankDev branch March 22, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim Awaiting requested review from tscrim

Assignees
No one assigned
Labels
c: categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HenryWu2101 @tscrim @vbraun