Skip to content

update networkx to 3.4.2 #39676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 22, 2025
Merged

update networkx to 3.4.2 #39676

merged 21 commits into from
Mar 22, 2025

Conversation

dcoudert
Copy link
Contributor

With the update of numpy and scipy (#39655), we can update networkx to version 3.4.2.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#39655

@dimpase
Copy link
Member

dimpase commented Mar 12, 2025

Please apply

--- a/build/pkgs/meson/version_requirements.txt
+++ b/build/pkgs/meson/version_requirements.txt
@@ -1 +1 @@
-meson
+meson >= 1.5.0

@dimpase
Copy link
Member

dimpase commented Mar 12, 2025

by the way, is there any reason for not using pypi wheel. A build from a tarfile takes a bit longer, and the tarfile is bigger than .whl file.
See https://pypi.org/project/networkx/#files

@dimpase
Copy link
Member

dimpase commented Mar 12, 2025

we need also to modify build/pkgs/meson/spkg-configure.m4
I'll prepare a patch and open a PR against this branch on your github. You'll need to merge it update this PR

@dimpase
Copy link
Member

dimpase commented Mar 12, 2025

@dcoudert please merge dcoudert#2

bump up external meson's minimal version for scipy
Copy link

Documentation preview for this PR (built with commit 6e06b66; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dcoudert
Copy link
Contributor Author

Thank you @dimpase. It was indeed easy to merge (first time I do that).

@dimpase
Copy link
Member

dimpase commented Mar 12, 2025

@tobiasdiez - some docker related CI runs error out due to

8063.9 make[2]: ./tools/test-git-no-uncommitted-changes: Command not found

some kind of version mismatch?

@tobiasdiez
Copy link
Contributor

@tobiasdiez - some docker related CI runs error out due to

8063.9 make[2]: ./tools/test-git-no-uncommitted-changes: Command not found

some kind of version mismatch?

I've seen this somewhere before (probably also in the incremental builds). The path is correct and exists, no idea why it's not found on CI. Maybe @kwankyu knows?

@dimpase
Copy link
Member

dimpase commented Mar 13, 2025

OK, LGTM. Please turn this to positive review

@dcoudert
Copy link
Contributor Author

Thank you !

vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 19, 2025
sagemathgh-39676: update networkx to 3.4.2
    
With the update of numpy and scipy (sagemath#39655), we can update networkx to
version 3.4.2.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#39655
    
URL: sagemath#39676
Reported by: David Coudert
Reviewer(s): Dima Pasechnik
@vbraun vbraun merged commit e14b0a2 into sagemath:develop Mar 22, 2025
24 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants