-
-
Notifications
You must be signed in to change notification settings - Fork 599
update networkx to 3.4.2 #39676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update networkx to 3.4.2 #39676
Conversation
also fix a related doctest in graphs
as autoconf's generated configure clobbers conftest*, we are saving conftest.py from it by making a backup copy and then restoring it after the real configure was run.
This reverts commit 48a81bd.
Please apply --- a/build/pkgs/meson/version_requirements.txt
+++ b/build/pkgs/meson/version_requirements.txt
@@ -1 +1 @@
-meson
+meson >= 1.5.0 |
by the way, is there any reason for not using pypi wheel. A build from a tarfile takes a bit longer, and the tarfile is bigger than .whl file. |
we need also to modify build/pkgs/meson/spkg-configure.m4 |
@dcoudert please merge dcoudert#2 |
bump up external meson's minimal version for scipy
Documentation preview for this PR (built with commit 6e06b66; changes) is ready! 🎉 |
Thank you @dimpase. It was indeed easy to merge (first time I do that). |
@tobiasdiez - some docker related CI runs error out due to
some kind of version mismatch? |
I've seen this somewhere before (probably also in the incremental builds). The path is correct and exists, no idea why it's not found on CI. Maybe @kwankyu knows? |
OK, LGTM. Please turn this to positive review |
Thank you ! |
sagemathgh-39676: update networkx to 3.4.2 With the update of numpy and scipy (sagemath#39655), we can update networkx to version 3.4.2. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#39655 URL: sagemath#39676 Reported by: David Coudert Reviewer(s): Dima Pasechnik
With the update of numpy and scipy (#39655), we can update networkx to version 3.4.2.
📝 Checklist
⌛ Dependencies
#39655