Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump executing to 2.2.0 #39602

Merged
merged 2 commits into from
Mar 9, 2025
Merged

bump executing to 2.2.0 #39602

merged 2 commits into from
Mar 9, 2025

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Feb 27, 2025

It's in particular needed to fix ipython error handling with Python 3.13
This will fix #39591

see #39591 (comment) by Tobias Diez

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

It's in particular needed to fix ipython error handling with Python 3.13

see sagemath#39591#issuecomment-2685649032 by Tobias Diez
@dimpase
Copy link
Member Author

dimpase commented Feb 27, 2025

@EmmanuelCharpentier - please review

@dimpase
Copy link
Member Author

dimpase commented Feb 27, 2025

@jhpalmieri - please review

@jhpalmieri
Copy link
Member

This builds for me with Python 3.12 and 3.13 on OS X, and it fixes some doctest failures. How is it on linux?

@EmmanuelCharpentier
Copy link
Contributor

EmmanuelCharpentier commented Feb 27, 2025 via email

@dimpase
Copy link
Member Author

dimpase commented Feb 27, 2025

This builds for me with Python 3.12 and 3.13 on OS X, and it fixes some doctest failures. How is it on linux?

It's in distros, e.g. Gentoo has it, without any patches. It works on Gentoo for sure.

@EmmanuelCharpentier
Copy link
Contributor

EmmanuelCharpentier commented Feb 27, 2025 via email

Copy link

github-actions bot commented Feb 27, 2025

Documentation preview for this PR (built with commit 24a418e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@EmmanuelCharpentier
Copy link
Contributor

EmmanuelCharpentier commented Feb 27, 2025 via email

@dimpase
Copy link
Member Author

dimpase commented Feb 27, 2025

your error messages say you either didn't do the update of Sages pillow and cffi, or did, but didn't run ./bootstrap && ./configure afterwards

@dimpase
Copy link
Member Author

dimpase commented Mar 8, 2025

ping?

@dimpase
Copy link
Member Author

dimpase commented Mar 8, 2025

Can we get this in - it's a trivial update. @vbraun

@EmmanuelCharpentier
Copy link
Contributor

This patch, along #39571, allowed me to compile and run successfully 10.6.beta7 and 10.6.beta8, whose ptestlong gave acceptable results.

Notwithstanding the fact that I didn't give this patch any specific test (outside the vanishing of the initial errors), I set "positive review`. Feel free to amend this...

@vbraun vbraun merged commit 0b5fa29 into sagemath:develop Mar 9, 2025
20 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10.6.beta7 breaks exception formatting
4 participants