some fixes for E114 #39564
Merged
some fixes for E114 #39564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 710acc3; changes) is ready! 🎉 |
dcoudert
reviewed
Feb 22, 2025
| @@ -1151,7 +1151,7 @@ def form_list_of_cusps(self): | |||
|
|
|||
| full_domain = False # Says that we are not done yet! | |||
|
|
|||
| v = [False for r in range(sP)] | |||
| v = [False for _ in range(sP)] | |||
There was a problem hiding this comment.
isn't it better to use v = [False] * SP ?
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 22, 2025
sagemathgh-39564: some fixes for E114 mostly fixing some E114 warnings about indentation of comments alos full pep8 cleanup in two of the modified files ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39564 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 24, 2025
sagemathgh-39564: some fixes for E114 mostly fixing some E114 warnings about indentation of comments alos full pep8 cleanup in two of the modified files ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39564 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly fixing some E114 warnings about indentation of comments
alos full pep8 cleanup in two of the modified files
📝 Checklist