Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on CI that update-meson is properly ran #39527

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Feb 14, 2025

Fixes #39172

Side note, can we just include the __init__.py to be tracked by git?

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes. (not applicable)
  • I have updated the documentation and checked the documentation preview. (no documentation change? Do we need to mention this in developer guide somewhere?)

⌛ Dependencies

@user202729 user202729 marked this pull request as draft February 14, 2025 13:53
@user202729 user202729 force-pushed the check-update-meson branch 2 times, most recently from 74afe78 to 627262f Compare February 14, 2025 14:14
Copy link

github-actions bot commented Feb 14, 2025

Documentation preview for this PR (built with commit 82a439a; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729 user202729 marked this pull request as ready for review February 14, 2025 15:31
@orlitzky
Copy link
Contributor

Side note, can we just include the __init__.py to be tracked by git?

@tobiasdiez tried this once and it launched a months-long battle. It affects the sagemath-{objects,categories,etc} namespace packages. Though at this point they are unmaintained, nobody should be using them, and we could be more pragmatic about fixing whatever goes wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools/update-meson.py is too undiscoverable
2 participants