-
-
Notifications
You must be signed in to change notification settings - Fork 602
Add minimal relation bases for univariate polynomial matrices #39516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimal relation bases for univariate polynomial matrices #39516
Conversation
Still to do: add interpolant bases, and the corresponding documentation and tests. For reference: this is based directly on a minimal kernel basis computation, with suitable degree constraints to ensure that the sought relation basis appears as a submatrix of this kernel basis. |
Documentation preview for this PR (built with commit 26316fc; changes) is ready! 🎉 |
This is ready for review. Note that approximant and interpolation bases could call relation bases with an input of some specific form. Yet having dedicated implementations does make a non-negligible difference in performance, see the timings below (ratios in columns
|
I saw in the reference manual that the methods |
Co-authored-by: Hugo Passe <[email protected]>
Thanks for the suggestion. Here are some thoughts on this question.
|
Concerning this last point, to complete my answer: the method So, to answer the initial question, I do not see a strong point in favor of adding the |
I did some tests and found a small issue. If you take Steps to reproduce:
|
Thanks for the comment. I have done some experiments and this is a more general problem among the available methods for these matrices. This would bring this PR too far from its original goal, so I propose to leave this as another task, cf issue #39587 created for this. |
LGTM |
Fixes #23645
This covers:
The focus of this PR is on providing methods that are as versatile/general as possible (while keeping performance at a reasonable level).
With regards to #23645 , note that approximant bases had already been integrated in SageMath some years ago. Thus with this PR all types of relation bases mentioned in that issue are now covered.