Skip to content

moving random_element to category of rings #39497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 21, 2025
Merged

moving random_element to category of rings #39497

merged 7 commits into from
Feb 21, 2025

Conversation

fchapoton
Copy link
Contributor

moving the random_element out of the auld Ring class

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 06530ce; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tscrim
Copy link
Collaborator

tscrim commented Feb 12, 2025 •
edited
Loading

Looks like some genuine failures:

sage -t --long --warn-long 30.0 --random-seed=286735480429121101562228604801325644303 src/sage/categories/sets_cat.py
sage -t --long --warn-long 30.0 --random-seed=286735480429121101562228604801325644303 src/sage/rings/finite_rings/integer_mod_ring.py  # 1 doctest failed

@fchapoton fchapoton added the sd128 tickets of Sage Days 128 Le Teich label Feb 15, 2025
tscrim
tscrim approved these changes Feb 16, 2025
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last little thing. Once done or you chose to ignore, you can set a positive review.

@fchapoton
Copy link
Contributor Author

Sure, but what exactly is this last change you would like ?

@tscrim
Copy link
Collaborator

tscrim commented Feb 18, 2025

Thank you.

@vbraun vbraun merged commit 3500f61 into sagemath:develop Feb 21, 2025
20 of 23 checks passed
@fchapoton fchapoton deleted the random_ring_cat branch February 22, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
sd128 tickets of Sage Days 128 Le Teich t: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @tscrim @vbraun @mantepse