Skip to content

Fix more doctests in meson_editable install #39494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2025
Merged

Fix more doctests in meson_editable install #39494

merged 2 commits into from
Feb 21, 2025

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Feb 11, 2025 •
edited
Loading

Fix more bugs uncovered by #39369 .

Add a feature flag meson_editable, and put doctests behind this flag accordingly.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@user202729 user202729 mentioned this pull request Feb 11, 2025
Merged
3 tasks
@user202729 user202729 marked this pull request as draft February 11, 2025 17:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

Documentation preview for this PR (built with commit b6cb2f4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729 user202729 force-pushed the fix-more-doctests-meson-editable branch from 40c0b19 to 3dc5ce3 Compare February 12, 2025 02:47
@user202729 user202729 marked this pull request as ready for review February 12, 2025 02:47
tobiasdiez
tobiasdiez approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@user202729
Copy link
Contributor Author

user202729 commented Feb 20, 2025 •
edited
Loading

That said, do you have any better way than using type(sage.__loader__).__module__ == '_sagemath_editable_loader' to check for the existence of the feature? Given the underscore it is quite obvious that it's meant to be an internal name.

@tobiasdiez
Copy link
Contributor

That said, do you have any better way than using type(sage.__loader__).__module__ == '_sagemath_editable_loader' to check for the existence of the feature? Given the underscore it is quite obvious that it's meant to be an internal name.

No not really. But in my opinion it's a good test since the loader is the most obvious indication that one is using meson in editable mode.

@vbraun vbraun merged commit 98eec5d into sagemath:develop Feb 21, 2025
17 of 23 checks passed
vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 9, 2025
2b842ce 
sagemathgh-39369: Test pip editable install with meson
    
Tests pip editable install with meson on GitHub Actions.

This uncovers several failing tests, which are fixed by (see
dependencies below)

Note: review is hard because of the large number of dependencies. It is
probably easier to look only in `.github` folder.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.

### ⌛ Dependencies


- sagemath#39423
- sagemath#39498
- sagemath#39494
- sagemath#39424
- sagemath#39275
- sagemath#39499
    
URL: sagemath#39369
Reported by: user202729
Reviewer(s): Tobias Diez, user202729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@user202729 @tobiasdiez @vbraun