Fixed crash when exp(0) of p-adic numbers is called #39479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I will set to positive review on Wednesday if there are no other comments and |
|
Oh, I missed this -- you do need to make one minor fix: There should only be one colon at the end of |
|
|
|
Sorry, you need to make another minor correction in line 2964: change |
|
Documentation preview for this PR (built with commit 56b0fc4; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38037. Fixes crash when exp(0) is called when using p-adic numbers. Since the unit part of 0 does not exist it was causing a crash. Therefore, to fix this bug we check if our exponent is exactly 0 and if it is return 1 immediately. Also added a doctest to verify that the issue has been fixed.
📝 Checklist
⌛ Dependencies