Trivial simplifications for arccos #39456
Merged
+14
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a couple of places where arccos doesn't automatically simplify for ratios arising from the unit circle (but arcsin does). Turns out that asin_eval has some logic handling unit circle cases directly that was not replicated in acos_eval. I copy-pasted the logic from asin_eval and modified appropriately. sagemath#24211
5 tasks
|
Documentation preview for this PR (built with commit 7c5d6dc; changes) is ready! 🎉 |
|
@tscrim : would you please have time for this little one ? I have just heard about snowing in Japan. ☃️ |
tscrim
approved these changes
Feb 10, 2025
|
Indeed, Hokkaido and northern Japan got a fair bit of snow. Now I have escaped to Singapore for the week. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 11, 2025
sagemathgh-39456: Trivial simplifications for arccos This is replacing sagemath#36069 supersedes sagemath#36069 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#39456 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2025
sagemathgh-39456: Trivial simplifications for arccos This is replacing sagemath#36069 supersedes sagemath#36069 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#39456 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is replacing #36069
supersedes #36069
📝 Checklist