Fixed randomly failing test in bigraphical hyperplane function #39432
Conversation
…a test failing every 1 in 1000 times. Made example have # random so it can fail and made a seperate test in the test block that runs the original test 5 times.
|
Thanks for doing this. However, the comment "We try" is not helpful. You could simply delete it, but I think it would be better to say something informative and mention the issue number, such as "One of the above examples was marked "# random" because the output is not always the same. However, the answer is "65" more than 99.9% of the time, so we can make a doctest by running it repeatedly (see :issue: |
|
Backticks are required around the issue number in the reference: it needs to be Sorry I didn't notice that the backticks didn't show up in my previous comment. |
|
Looks good. I will run |
|
|
sagemathgh-39432: Fixed randomly failing test in bigraphical hyperplane function Fixes sagemath#39167. Fixed a doctest in the bigraphical function for hyperplanes that had a test failing every 1 in 1000 times. Made example have # random so it can fail and made a separate test in the test block that runs the original test 5 times. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [X] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies URL: sagemath#39432 Reported by: Noel-Roemmele Reviewer(s):
sagemathgh-39432: Fixed randomly failing test in bigraphical hyperplane function Fixes sagemath#39167. Fixed a doctest in the bigraphical function for hyperplanes that had a test failing every 1 in 1000 times. Made example have # random so it can fail and made a separate test in the test block that runs the original test 5 times. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [X] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies URL: sagemath#39432 Reported by: Noel-Roemmele Reviewer(s):
Fixes #39167. Fixed a doctest in the bigraphical function for hyperplanes that had a test failing every 1 in 1000 times. Made example have # random so it can fail and made a separate test in the test block that runs the original test 5 times.
📝 Checklist
⌛ Dependencies