-
-
Notifications
You must be signed in to change notification settings - Fork 599
breaking lines after else: in pyx files #39393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation preview for this PR (built with commit 11cba3d; changes) is ready! 🎉 |
You make changes preferring (A)
over (B)
I agree, but some authors prefer (B) in some cases. Does our linter check against (B)? |
thanks for the review. I have made the suggested change and fix. Concerning the removal of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
sagemathgh-39393: breaking lines after else: in pyx files as this is already done in all .py files and almost all pyx files ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39393 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Kwankyu Lee
sagemathgh-39393: breaking lines after else: in pyx files as this is already done in all .py files and almost all pyx files ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39393 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Kwankyu Lee
as this is already done in all .py files and almost all pyx files
📝 Checklist