some fixes for PLR1716 #39354
Merged
some fixes for PLR1716 #39354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit f6311ca; changes) is ready! 🎉 |
mantepse
reviewed
Jan 20, 2025
| return False | ||
| return lower_widths[h] <= w < lower_widths[h] + widths[h] | ||
| return 0 | ||
| if lower_widths[h] <= w and w < lower_widths[h] + widths[h]: |
There was a problem hiding this comment.
if lower_widths[h] <= w < lower_widths[h] + widths[h]:
should be correct.
There was a problem hiding this comment.
Ah, I see, you decided not to touch the file at all!
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 23, 2025
sagemathgh-39354: some fixes for PLR1716 which is about using the syntax `a < b < c` when possible ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39354 Reported by: Frédéric Chapoton Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 25, 2025
sagemathgh-39354: some fixes for PLR1716 which is about using the syntax `a < b < c` when possible ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39354 Reported by: Frédéric Chapoton Reviewer(s): Martin Rubey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which is about using the syntax
a < b < cwhen possible📝 Checklist