Skip to content

Fix broken sat solvers feature tests #39344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

antonio-rojas
Copy link
Contributor

@antonio-rojas antonio-rojas commented Jan 18, 2025

GlucoseExecutable, PycosatExecutable and PycryptosatExecutable are nowhere defined.

Copy link

Documentation preview for this PR (built with commit 603fbd7; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase
Copy link
Member

dimpase commented Jan 19, 2025

hmm, why do you change these, but not similar things like

src/sage/features/nauty.py:        sage: NautyExecutable('converseg').is_present()

What's broken?

@antonio-rojas
Copy link
Contributor Author

antonio-rojas commented Jan 19, 2025

NautyExecutable is a class defined in sage/features/nauty.py. OTOH GlucoseExecutable, PycosatExecutable and PycryptosatExecutable do not exist at all, so these tests are totally broken

File "/usr/lib/python3.13/site-packages/sage/features/sat.py", line 62, in sage.features.sat.Pycosat
Failed example:
    PycosatExecutable().is_present()                  # optional - pycosat
Exception raised:
    Traceback (most recent call last):
      File "/usr/lib/python3.13/site-packages/sage/doctest/forker.py", line 728, in _run
        self.compile_and_execute(example, compiler, test.globs)
        ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/usr/lib/python3.13/site-packages/sage/doctest/forker.py", line 1152, in compile_and_execute
        exec(compiled, globs)
        ~~~~^^^^^^^^^^^^^^^^^
      File "<doctest sage.features.sat.Pycosat[1]>", line 1, in <module>
        PycosatExecutable().is_present()                  # optional - pycosat
        ^^^^^^^^^^^^^^^^^
    NameError: name 'PycosatExecutable' is not defined

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 23, 2025
sagemathgh-39344: Fix broken sat solvers feature tests
    
`GlucoseExecutable`, `PycosatExecutable` and `PycryptosatExecutable`
are nowhere defined.
    
URL: sagemath#39344
Reported by: Antonio Rojas
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 25, 2025
sagemathgh-39344: Fix broken sat solvers feature tests
    
`GlucoseExecutable`, `PycosatExecutable` and `PycryptosatExecutable`
are nowhere defined.
    
URL: sagemath#39344
Reported by: Antonio Rojas
Reviewer(s): Dima Pasechnik
@vbraun vbraun merged commit 0037c7c into sagemath:develop Jan 27, 2025
18 of 23 checks passed
@antonio-rojas antonio-rojas deleted the fix-sat-test branch January 27, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants