add an iterator over the minimal separators of a graph #39341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 2c56090; changes) is ready! 🎉 |
|
Is storing all the separators necessary for the algorithm? It's kind of silly to return an iterator over an explicitly computed set, rather than the whole set itself |
|
With this algorithm, I don't know how to avoid storing separators. At least, at any time, the algorithm stores as many separators as it has already yielded. |
dimpase
approved these changes
Jan 20, 2025
|
Thank you for the review. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 23, 2025
sagemathgh-39341: add an iterator over the minimal separators of a graph Fixes sagemath#37743. Adds an iterator over the minimal separators of an undirected graphs. We also fix the behavior of some methods using parameter `forbidden_vertices` (added in sagemath#39151) when the input is an iterator. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39341 Reported by: David Coudert Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 25, 2025
sagemathgh-39341: add an iterator over the minimal separators of a graph Fixes sagemath#37743. Adds an iterator over the minimal separators of an undirected graphs. We also fix the behavior of some methods using parameter `forbidden_vertices` (added in sagemath#39151) when the input is an iterator. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39341 Reported by: David Coudert Reviewer(s): Dima Pasechnik
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37743.
Adds an iterator over the minimal separators of an undirected graphs.
We also fix the behavior of some methods using parameter
forbidden_vertices(added in #39151) when the input is an iterator.📝 Checklist
⌛ Dependencies