Improve hack used in debug_options #39093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user202729
force-pushed
the
remove-debug-options-hack
branch
from
0b5bc03 to
6d6ce3b
Compare
user202729
force-pushed
the
remove-debug-options-hack
branch
2 times, most recently
from
c508b2e to
64b4f9f
Compare
user202729
changed the title
user202729
force-pushed
the
remove-debug-options-hack
branch
from
64b4f9f to
320daec
Compare
|
Documentation preview for this PR (built with commit 3e6d549; changes) is ready! 🎉 |
|
I don't know this stuff. But your hack seems simpler and works. |
kwankyu
approved these changes
Feb 10, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 11, 2025
sagemathgh-39093: Improve hack used in debug_options The `__pyx_d` no longer works in newer cython versions. This should works better. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39093 Reported by: user202729 Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2025
sagemathgh-39093: Improve hack used in debug_options The `__pyx_d` no longer works in newer cython versions. This should works better. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39093 Reported by: user202729 Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__pyx_dno longer works in newer cython versions. This should works better.📝 Checklist
⌛ Dependencies