-
-
Notifications
You must be signed in to change notification settings - Fork 599
Remove erroneous member declaration in farey_symbol #39092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weird but… looks unrelated to the change…? I guess I'll just wait for these (unrelated) issues to be fixed in master. Repush to re-trigger GitHub actions. |
Documentation preview for this PR (built with commit e9dcaf2; changes) is ready! 🎉 |
183e21f
to
c0e9b90
Compare
saraedum
approved these changes
Feb 13, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2025
sagemathgh-39092: Remove erroneous member declaration in farey_symbol As you can see in the C++ header file, there is in fact no members named `a, b, c, d`. In fact it's an error in C++ to have a member function and member variable with the same name. Newer versions of Cython gives hard-to-debug errors for this. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39092 Reported by: user202729 Reviewer(s): Julian Rüth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see in the C++ header file, there is in fact no members named
a, b, c, d
. In fact it's an error in C++ to have a member function and member variable with the same name.Newer versions of Cython gives hard-to-debug errors for this.
📝 Checklist
⌛ Dependencies