Turn some doctests in ell_rational_field.py into long tests
#38824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit aeb512f; changes) is ready! 🎉 |
|
probably a side-effect of #38461 |
fchapoton
reviewed
Oct 18, 2024
|
I can't reproduce the timeout of |
fchapoton
added
s: positive review
sd128
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2025
sagemathgh-38824: Turn some doctests in `ell_rational_field.py` into long tests Fixes sagemath#38813 Some of the doctests in `ell_rational_field.py` ran into RuntimeErrors and couldn't compute generators in time, causing tests to fail. Turning them into long tests (which is necessary since they have to run longer in some cases) fixes that problem. Also added some missing spaces. URL: sagemath#38824 Reported by: Sebastian A. Spindler Reviewer(s): Frédéric Chapoton, Sebastian A. Spindler
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 22, 2025
sagemathgh-39567: Make test deterministic to fix CI Apparently the test is introduced in sagemath#38824 and it's basically copied from another test below that is marked `random` ``` sage: E = EllipticCurve([-127^2,0]) sage: E.gens(use_database=False, algorithm='pari', pari_effort=4) # long time, random [(611429153205013185025/9492121848205441 : 15118836457596902442737698070880/924793900700594415341761 : 1)] ``` I don't know why this one isn't marked `# random` but I choose to keep checking the output but does it more carefully. Basically it has rank 1 so the generator is determined up to `± 1` and modulo torsion, so we just need to check `l[0] - a` or `l[0] + a` is in torsion. It's not clear why the test starts failing now. Maybe it's just random after all. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39567 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 24, 2025
sagemathgh-39567: Make test deterministic to fix CI Apparently the test is introduced in sagemath#38824 and it's basically copied from another test below that is marked `random` ``` sage: E = EllipticCurve([-127^2,0]) sage: E.gens(use_database=False, algorithm='pari', pari_effort=4) # long time, random [(611429153205013185025/9492121848205441 : 15118836457596902442737698070880/924793900700594415341761 : 1)] ``` I don't know why this one isn't marked `# random` but I choose to keep checking the output but does it more carefully. Basically it has rank 1 so the generator is determined up to `± 1` and modulo torsion, so we just need to check `l[0] - a` or `l[0] + a` is in torsion. It's not clear why the test starts failing now. Maybe it's just random after all. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39567 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 27, 2025
sagemathgh-39567: Make test deterministic to fix CI Apparently the test is introduced in sagemath#38824 and it's basically copied from another test below that is marked `random` ``` sage: E = EllipticCurve([-127^2,0]) sage: E.gens(use_database=False, algorithm='pari', pari_effort=4) # long time, random [(611429153205013185025/9492121848205441 : 15118836457596902442737698070880/924793900700594415341761 : 1)] ``` I don't know why this one isn't marked `# random` but I choose to keep checking the output but does it more carefully. Basically it has rank 1 so the generator is determined up to `± 1` and modulo torsion, so we just need to check `l[0] - a` or `l[0] + a` is in torsion. It's not clear why the test starts failing now. Maybe it's just random after all. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39567 Reported by: user202729 Reviewer(s): Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38813
Some of the doctests in
ell_rational_field.pyran into RuntimeErrors and couldn't compute generators in time, causing tests to fail. Turning them into long tests (which is necessary since they have to run longer in some cases) fixes that problem.Also added some missing spaces.