Allow .maximal_order() of quaternion_algebra.py to extend a given order
#37675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and small refactoring of code
tscrim
requested changes
Apr 6, 2024
Caused by switched order of input arguments Amend: This time for real
S17A05
force-pushed
the
maximal_extension
branch
from
c9885e1 to
c29ee5c
Compare
|
Documentation preview for this PR (built with commit bf39355; changes) is ready! 🎉 |
|
The testing timeout of |
Credit to @tscrim for the help on how to do this!
tscrim
approved these changes
Apr 18, 2024
- Corrected order of additional arguments - Fixed spacing for PEP8
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 20, 2024
sagemathgh-37675: Allow `.maximal_order()` of `quaternion_algebra.py` to extend a given order 1. Added an optional argument `order_basis` to `.maximal_order()` to allow for extension of orders: If `order_basis` defines an order of the given quaternion algebra, then the method now returns a maximal order that contains the order specified by the given basis. ~~2. Added comparison functions `__le__`, `__ge__`, `__lt__` and `__gt__` for quaternion orders.~~ ~~3. Small edits of the comparison functions `__eq__` and `__ne__` for quaternion orders.~~ 2. Added a general comparison function `__richcmp__` for quaternion orders and removed the explicit implementation of `__eq__` and `__ne__`. More details on 1.: The algorithm used in `.maximal_order()` currently uses the standard basis `(1,i,j,k)` as a starting basis, but it extends to any starting basis whose first entry is equal to `1`. Using the helper method `basis_for_quaternion_lattice`, we transform any quaternion order basis input by the user to a basis of this form. Depends on sagemath#37644: Naturally, the extended algorithm can only work correctly if the base algorithm works correctly in the first place. URL: sagemath#37675 Reported by: Sebastian A. Spindler Reviewer(s): Sebastian A. Spindler, Travis Scrimshaw
S17A05
added a commit
to Eloitor/sagemath
that referenced
this pull request
Feb 21, 2025
- Added missing tests for possible errors - Integrated `.ramified_places()` to check that new construction works correctly - Modified input checks to properly reject bad inputs - Added author entry for prior work on sagemath#37173, sagemath#37644 and sagemath#37675
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
order_basisto.maximal_order()to allow for extension of orders: Iforder_basisdefines an order of the given quaternion algebra, then the method now returns a maximal order that contains the order specified by the given basis.2. Added comparison functions__le__,__ge__,__lt__and__gt__for quaternion orders.3. Small edits of the comparison functions__eq__and__ne__for quaternion orders.__richcmp__for quaternion orders and removed the explicit implementation of__eq__and__ne__.More details on 1.:
The algorithm used in
.maximal_order()currently uses the standard basis(1,i,j,k)as a starting basis, but it extends to any starting basis whose first entry is equal to1. Using the helper methodbasis_for_quaternion_lattice, we transform any quaternion order basis input by the user to a basis of this form.Depends on #37644: Naturally, the extended algorithm can only work correctly if the base algorithm works correctly in the first place.