Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to jupyterlab 4.1.3 and notebook 7.1.1 #37535

Merged
6 commits merged into from
Mar 17, 2024
Merged

Upgrade to jupyterlab 4.1.3 and notebook 7.1.1 #37535

6 commits merged into from
Mar 17, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 3, 2024 •
edited
Loading

Fixes #37533

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 3, 2024
@mkoeppe mkoeppe self-assigned this Mar 3, 2024
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 3, 2024 

[jupyterlab-4.1.2] ERROR: Could not find a version that satisfies the requirement httpx>=0.25.0 (from jupyterlab) (from versions: none)
[jupyterlab-4.1.2] ERROR: No matching distribution found for httpx>=0.25.0

@mkoeppe mkoeppe requested a review from egourgoulhon March 3, 2024 23:13
@mkoeppe mkoeppe changed the title Upgrade to jupyterlab 4.1.2 and notebook 7.1.1 Upgrade to jupyterlab 4.1.3 and notebook 7.1.1 Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Documentation preview for this PR (built with commit 04b6d8e; changes) is ready! 🎉

@mkoeppe mkoeppe requested a review from culler March 7, 2024 20:10
@culler culler mentioned this pull request Mar 10, 2024
Closed
5 tasks
culler
culler reviewed Mar 10, 2024
View reviewed changes
Copy link
Contributor

@culler culler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, as far as it goes. But I think that Sage should really update as many of the dependencies of the jupyterlab and notebook packages as possible. Please see PR #37581, where I attempted to do this.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2024

Unlikely that we can get the bigger upgrade into 10.3.
So let's set this one here to "positive review" and "blocker" (so it will be considered for merging)?

@culler
Copy link
Contributor

culler commented Mar 10, 2024

OK. Fine with me.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 10, 2024

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 14, 2024
e850ac9 
sagemathgh-37535: Upgrade to jupyterlab 4.1.3 and notebook 7.1.1
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- https://github.com/jupyter/notebook/releases/tag/v7.1.0
- https://jupyterlab.readthedocs.io/en/stable/getting_started/changelog.
html#v4-1

Fixes sagemath#37533

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37535
Reported by: Matthias Köppe
Reviewer(s): Marc Culler
@vbraun vbraun closed this pull request by merging all changes into sagemath:develop in ab1a517 Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@culler culler culler left review comments

@egourgoulhon egourgoulhon Awaiting requested review from egourgoulhon

Assignees

@mkoeppe mkoeppe

Labels
c: packages: standard c: user interface p: blocker / 1
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

Sage should upgrade to jupyterlab 4.1.3 and notebook 7.1.1 for 10.3
3 participants
@mkoeppe @culler @vbraun