Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Parent in Weyl algebra #37303

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Conversation

fchapoton
Copy link
Contributor

replace the auld-class Algebra by Parent in Weyl algebras

this requires a tweak in the _first_n_gens mechanism to handle families

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly a triviality. Whether you change it or not, you can set a positive review once decided.

Copy link

Documentation preview for this PR (built with commit c817c06; changes) is ready! 🎉

@tscrim
Copy link
Collaborator

tscrim commented Feb 13, 2024

Thank you.

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 18, 2024
sagemathgh-37303: use Parent in Weyl algebra
    
replace the auld-class `Algebra` by `Parent` in Weyl algebras

this requires a tweak in the `_first_n_gens` mechanism to handle
families

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37303
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 19, 2024
sagemathgh-37303: use Parent in Weyl algebra
    
replace the auld-class `Algebra` by `Parent` in Weyl algebras

this requires a tweak in the `_first_n_gens` mechanism to handle
families

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37303
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit c1f5625 into sagemath:develop Feb 25, 2024
22 checks passed
@fchapoton fchapoton deleted the use_Parent_in_Weyl branch February 25, 2024 12:27
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants