Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some cython-lint fixes in ecl lib #37230

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

fchapoton
Copy link
Contributor

a few details as suggested by cython-lint and pycodestyle in libs/ecl.pyx

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Copy link

github-actions bot commented Feb 3, 2024

Documentation preview for this PR (built with commit f014a38; changes) is ready! 🎉

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 7, 2024
sagemathgh-37230: some cython-lint fixes in ecl lib
    
a few details as suggested by `cython-lint` and `pycodestyle` in
`libs/ecl.pyx`

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37230
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit 3d38254 into sagemath:develop Feb 13, 2024
21 of 22 checks passed
@fchapoton fchapoton deleted the cylint-ecl branch February 14, 2024 07:13
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants