Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix names of Gentoo packages #37212

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Conversation

saraedum
Copy link
Member

@saraedum saraedum commented Jan 31, 2024

Gentoo renamed some build tools in late 2023. We update the names here to fix the broken CI runs for Gentoo (that happen e.g. for cypari2.)

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion. (Offline discussion at SageDays, i.e., cypari builds are broken.)
  • I have created tests covering the changes. (There's already plenty of Gentoo CI in our setup that fails without this.)
  • I have updated the documentation accordingly. Nothing to do there.

⌛ Dependencies

Gentoo renamed some build tools in late 2023. We update the names here
to fix the broken CI runs for Gentoo (that happen e.g. for cypari2.)
@saraedum
Copy link
Member Author

@saraedum saraedum requested a review from fchapoton January 31, 2024 22:29
@saraedum
Copy link
Member Author

@fchapoton I am waiting to see if the Gentoo CI manages to install make.

@fchapoton
Copy link
Contributor

maybe this specific CI needs to be triggered manually ?

saraedum added a commit to saraedum/cypari2 that referenced this pull request Feb 1, 2024
saraedum added a commit to saraedum/cypari2 that referenced this pull request Feb 1, 2024
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w.r.t. the package names (checked on a real gentoo box). If something in CI needs fixing then it could be done in a followup.

@dimpase
Copy link
Member

dimpase commented Feb 1, 2024

@kiwifb @orlitzky

Copy link

github-actions bot commented Feb 1, 2024

Documentation preview for this PR (built with commit 57fb2a2; changes) is ready! 🎉

@saraedum
Copy link
Member Author

saraedum commented Feb 1, 2024

@fchapoton, Gentoo tests pass with these changes over at cypari2: sagemath/cypari2#153

@kiwifb
Copy link
Member

kiwifb commented Feb 1, 2024

@kiwifb @orlitzky

LGTM

@vbraun vbraun merged commit a958e5b into sagemath:develop Feb 2, 2024
30 of 34 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sd125 sage days 125
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants