-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added .is_isomorphic
for rational quaternion algebras
#37107
Conversation
Added `QuaternionAlgebra_ab.is_isomorphic()` to conveniently check whether two rational quaternion algebras are isomorphic
Could you add a type check to verify that |
34aa814
to
4fc542c
Compare
Added a check to make sure |
Added a type check to .is_isomorphic to ensure that A is a quaternion algebra of the form (a,b)_K.
Modified the error message to exclude the word rational since the base field of both quaternion algebras is only checked afterwards. |
Documentation preview for this PR (built with commit e3e69c2; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
.is_isomorphic
for rational quaternion algebras
Added
QuaternionAlgebra_ab.is_isomorphic()
to conveniently check whether two rational quaternion algebras are isomorphic.TODO (future work):
#sd123