Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added third embedding in Cubegraph for oblique projection of hypercubes #37045

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

amanmoon
Copy link
Contributor

@amanmoon amanmoon commented Jan 12, 2024

Added third embedding for oblique projection of hypercube.

Output after changes:

graphs.CubeGraph(3, 3).plot() gives:

tmp_zjbpqfvb

graphs.CubeGraph(4, 3).plot() gives:

tmp_42b4cb_b

Fixes #37040

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.

@dcoudert
Copy link
Contributor

I don't think that the proposed modification is in accordance with the documentation. Please check. May be you want to add a third method to embed the Cube graph ?

@amanmoon
Copy link
Contributor Author

amanmoon commented Jan 16, 2024

I added a 3rd embedding in the CubeGraph corresponding to the oblique projection of the hypercube.

Copy link

Documentation preview for this PR (built with commit c39ca6f; changes) is ready! 🎉

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The drawings in dimensions 3, 4 and 5 are really useful. Thank you.

@amanmoon amanmoon changed the title Fix bug in CubeGraph(3)._pos which now returns each vertex in different spot Added third embedding in Cubegraph for oblique projection of hypercubes Jan 16, 2024
@vbraun vbraun merged commit b4a9bad into sagemath:develop Jan 22, 2024
3 checks passed
@amanmoon amanmoon deleted the bug/HyperCube_CubeGraph_pos branch January 23, 2024 18:52
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pos_dict of CubeGraph(3) is not useful
4 participants