Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More conversion to parent #36933

Merged
merged 4 commits into from
Jan 14, 2024
Merged

Conversation

fchapoton
Copy link
Contributor

a few more conversions from Ring (old coercion framework) to Parent (new coercion framework),

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun
Copy link
Member

vbraun commented Dec 26, 2023

merge conflict

Copy link

Documentation preview for this PR (built with commit 1cb499e; changes) is ready! 🎉

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 2, 2024
sagemathgh-36933: More conversion to parent
    
a few more conversions from `Ring` (old coercion framework) to `Parent`
(new coercion framework),

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
    
URL: sagemath#36933
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 5, 2024
sagemathgh-36933: More conversion to parent
    
a few more conversions from `Ring` (old coercion framework) to `Parent`
(new coercion framework),

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
    
URL: sagemath#36933
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit 6df3377 into sagemath:develop Jan 14, 2024
@mkoeppe mkoeppe added this to the sage-10.3 milestone Jan 14, 2024
@fchapoton fchapoton deleted the more_conversion_to_Parent branch January 15, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants