Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spkg-src scripts for packages with real upstream url #36918

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Remove spkg-src scripts for packages with real upstream url #36918

merged 2 commits into from
Jan 14, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Dec 19, 2023

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Dec 19, 2023
kwankyu
kwankyu approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@kwankyu
Copy link
Collaborator

kwankyu commented Jan 2, 2024

But you may want to remove patches directory from build/pkgs/glpk?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 2, 2024 •
edited
Loading

Not the whole patches/, but patches/src, yes. Done in 5d593d5

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 2, 2024

Thanks!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024

Documentation preview for this PR (built with commit 5d593d5; changes) is ready! 🎉

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 5, 2024
54931e9 
sagemathgh-36918: Remove `spkg-src` scripts for packages with real upstream url
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36918
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit aa4c42e into sagemath:develop Jan 14, 2024
@mkoeppe mkoeppe added this to the sage-10.3 milestone Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: distribution
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @kwankyu @vbraun