fixing one bug in the use of valuation #36882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
reviewed
Dec 19, 2023
|
Thanks. Although it looks like something went wrong with a merge or rebase. |
fchapoton
force-pushed
the
fix_valuation_usage
branch
from
94e6d56 to
c74f555
Compare
|
indeed, should be better now |
|
Documentation preview for this PR (built with commit c74f555; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 21, 2023
sagemathgh-36882: fixing one bug in the use of valuation Trying to divide by an integer was failing here: ``` sage: L=PowerSeriesRing(QQ,'t') sage: t=L.gen() sage: F=algebras.Free(L,['A','B','C']) sage: A,B,C=F.gens() sage: f=t*A+t**2*B/2 # BUG HERE ``` and the same for Lazy power series. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. URL: sagemath#36882 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 22, 2023
sagemathgh-36882: fixing one bug in the use of valuation Trying to divide by an integer was failing here: ``` sage: L=PowerSeriesRing(QQ,'t') sage: t=L.gen() sage: F=algebras.Free(L,['A','B','C']) sage: A,B,C=F.gens() sage: f=t*A+t**2*B/2 # BUG HERE ``` and the same for Lazy power series. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. URL: sagemath#36882 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 23, 2023
sagemathgh-36882: fixing one bug in the use of valuation Trying to divide by an integer was failing here: ``` sage: L=PowerSeriesRing(QQ,'t') sage: t=L.gen() sage: F=algebras.Free(L,['A','B','C']) sage: A,B,C=F.gens() sage: f=t*A+t**2*B/2 # BUG HERE ``` and the same for Lazy power series. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. URL: sagemath#36882 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 24, 2023
sagemathgh-36882: fixing one bug in the use of valuation Trying to divide by an integer was failing here: ``` sage: L=PowerSeriesRing(QQ,'t') sage: t=L.gen() sage: F=algebras.Free(L,['A','B','C']) sage: A,B,C=F.gens() sage: f=t*A+t**2*B/2 # BUG HERE ``` and the same for Lazy power series. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. URL: sagemath#36882 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 25, 2023
Trying to divide by an integer was failing here: ``` sage: L=PowerSeriesRing(QQ,'t') sage: t=L.gen() sage: F=algebras.Free(L,['A','B','C']) sage: A,B,C=F.gens() sage: f=t*A+t**2*B/2 # BUG HERE ``` and the same for Lazy power series. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. URL: sagemath#36882 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to divide by an integer was failing here:
and the same for Lazy power series.
📝 Checklist