Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various details in modules folder (ruff, cython-lint, roles) #36856

Merged
merged 1 commit into from
Dec 14, 2023
Merged

various details in modules folder (ruff, cython-lint, roles) #36856

merged 1 commit into from
Dec 14, 2023

Conversation

fchapoton
Copy link
Contributor

This is fixing various little details in the modules folders, including some suggestions from ruff and cython-lint.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit ccfbd09; changes) is ready! 🎉

mkoeppe
mkoeppe approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbraun vbraun merged commit 69d5801 into sagemath:develop Dec 14, 2023
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 14, 2023
@fchapoton fchapoton deleted the some_details_in_modules branch December 14, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @mkoeppe @vbraun