Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permutation_normal_form : case of empty matrices #36634

Merged
merged 2 commits into from
Nov 5, 2023
Merged

permutation_normal_form : case of empty matrices #36634

merged 2 commits into from
Nov 5, 2023

Conversation

fchapoton
Copy link
Contributor

fixes #36629

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.

@fchapoton fchapoton changed the title case of empty matrices permutation_normal_form : case of empty matrices Nov 3, 2023
mkoeppe
mkoeppe approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@mkoeppe mkoeppe added this to the sage-10.2 milestone Nov 3, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Documentation preview for this PR (built with commit 15dd435; changes) is ready! 🎉

@vbraun vbraun merged commit a54d377 into sagemath:develop Nov 5, 2023
@fchapoton fchapoton deleted the empty_matrix_normal_form branch November 5, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
c: linear algebra t: bug
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.

Matrix permutation normal form raises an error on empty matrices
3 participants
@fchapoton @mkoeppe @vbraun