Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude symlinks from vscode search config via glob pattern #36511

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Exclude symlinks from vscode search config via glob pattern #36511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,14 @@
"src/**/*.so": true
},
"search.exclude": {
"build/pkgs/sagemath_categories/src": true,
"build/pkgs/sagemath_objects/src": true,
"build/pkgs/sagelib/src": true,
"pkgs/sage-conf_pypi/sage_root/build": true,
"pkgs/sagemath-categories/sage": true,
"pkgs/sagemath-objects/sage": true,
"pkgs/sagemath-standard/sage": true
// Exclude symbolic links into SAGE_ROOT/pkgs/
"build/pkgs/*/src": true,
// Exclude symbolic links into SAGE_ROOT/src/
"pkgs/sage-conf_conda/sage_root": true,
"pkgs/sage-conf_pypi/sage_root": true,
"pkgs/sage-docbuild/sage_docbuild": true,
"pkgs/sage-setup/sage_setup": true,
"pkgs/sagemath-*/sage": true
},
"python.testing.pytestEnabled": true,
"python.testing.pytestArgs": [
Expand Down
3 changes: 0 additions & 3 deletions src/doc/en/developer/packaging_sage_library.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,6 @@ The technique of using symbolic links pointing into ``SAGE_ROOT/src``
has allowed the modularization effort to keep the ``SAGE_ROOT/src``
tree monolithic: Modularization has been happening behind the scenes
and will not change where Sage developers find the source files.
When adding a new distribution package that uses a symbolic link pointing into
``SAGE_ROOT/src``, please update ``search.exclude`` in
``SAGE_ROOT/.vscode/settings.json``.

Some of these files may actually be generated from source files with suffix ``.m4`` by the
``SAGE_ROOT/bootstrap`` script via the ``m4`` macro processor.
Expand Down