Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

two minor details in groups #36398

Merged
merged 1 commit into from
Oct 14, 2023
Merged

two minor details in groups #36398

merged 1 commit into from
Oct 14, 2023

Conversation

fchapoton
Copy link
Contributor

fixing the category of dual abelian groups

fixing one of those pesting #needs annotation

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Documentation preview for this PR (built with commit 6bf4091; changes) is ready! 🎉

@fchapoton
Copy link
Contributor Author

@tscrim would you have time to have a look ? should be an easy one.

tscrim
tscrim approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder why this was (still) a todo?

PS - I really am starting to hate the codecov reports, it just is complicating looking at the files, especially around code that is not changed.

@vbraun vbraun merged commit 9867e78 into sagemath:develop Oct 14, 2023
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 14, 2023
@fchapoton fchapoton deleted the minor_cat_groups branch October 15, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: group theory
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @tscrim @vbraun @mkoeppe